Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump macos-12 runner to macos-13 #410

Merged
merged 4 commits into from
Nov 28, 2024
Merged

ci: Bump macos-12 runner to macos-13 #410

merged 4 commits into from
Nov 28, 2024

Conversation

justinvp
Copy link
Member

actions/runner-images#10721:

GitHub Actions is starting the deprecation process for macOS 12. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24

To raise awareness of the upcoming removal, we will temporarily fail jobs using macOS 12. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:

  • November 4, 14:00 UTC - November 5, 00:00 UTC
  • November 11, 14:00 UTC - November 12, 00:00 UTC
  • November 18, 14:00 UTC - November 19, 00:00 UTC
  • November 25, 14:00 UTC - November 26, 00:00 UTC

Target date

December 3rd, 2024

actions/runner-images#10721:

> GitHub Actions is starting the deprecation process for `macOS 12`. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24
>
> To raise awareness of the upcoming removal, we will temporarily fail jobs using `macOS 12`. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times:
>
> * November 4, 14:00 UTC - November 5, 00:00 UTC
> * November 11, 14:00 UTC - November 12, 00:00 UTC
> * November 18, 14:00 UTC - November 19, 00:00 UTC
> * November 25, 14:00 UTC - November 26, 00:00 UTC
>
> ### Target date
> December 3rd, 2024
@justinvp justinvp requested a review from a team as a code owner November 25, 2024 09:24
@justinvp justinvp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 25, 2024
Copy link
Contributor

@julienp julienp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, let's get this in before today's brownout :)

Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update https://www.pulumi.com/docs/iac/download-install/ to refer to at least 13 now?

@julienp
Copy link
Contributor

julienp commented Nov 25, 2024

Should we update https://www.pulumi.com/docs/iac/download-install/ to refer to at least 13 now?

Yes, I would say so. Apple is not very forthcoming with official support dates (I think macOS-12 is unsupported), but I think if we support the last 3 releases we're pretty good. And with GitHub deprecating macOS-12, our hands are tied anyway.

@justinvp
Copy link
Member Author

Should we update https://www.pulumi.com/docs/iac/download-install/ to refer to at least 13 now?

Yes, I'll open a PR. The version we're mentioning in the docs is quite out-of-date. It's referencing macOS 10.12 Sierra from 8 years ago, not macOS 12 Monterey from 3 years ago.

FYI: https://endoflife.date/macos

@julienp
Copy link
Contributor

julienp commented Nov 25, 2024

It's referencing macOS 10.12 Sierra from 8 years ago, not macOS 12 Monterey

🤣

@justinvp
Copy link
Member Author

pulumi/docs#13428

Allow specifying an explicit TargetFramework for integration test .csproj projects via a `TARGET_FRAMEWORK` envvar.

We need this because the macos-13 runner doesn't install .NET 6 by default, which causes tests to fail for the .NET 8 job.
IsMatch now has an overload, so we have to specify the type to disambiguate.
@justinvp justinvp added this pull request to the merge queue Nov 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 27, 2024
@justinvp justinvp added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit eaef9b8 Nov 28, 2024
17 checks passed
@justinvp justinvp deleted the justin/macos-13 branch November 28, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants