-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Bump macos-12 runner to macos-13 #410
Conversation
actions/runner-images#10721: > GitHub Actions is starting the deprecation process for `macOS 12`. While the image is being deprecated, You may experience longer queue times during peak usage hours. Deprecation will begin on 10/7/24 and the image will be fully unsupported by 12/3/24 > > To raise awareness of the upcoming removal, we will temporarily fail jobs using `macOS 12`. Builds that are scheduled to run during the brownout periods will fail. The brownouts are scheduled for the following dates and times: > > * November 4, 14:00 UTC - November 5, 00:00 UTC > * November 11, 14:00 UTC - November 12, 00:00 UTC > * November 18, 14:00 UTC - November 19, 00:00 UTC > * November 25, 14:00 UTC - November 26, 00:00 UTC > > ### Target date > December 3rd, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, let's get this in before today's brownout :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update https://www.pulumi.com/docs/iac/download-install/ to refer to at least 13 now?
Yes, I would say so. Apple is not very forthcoming with official support dates (I think macOS-12 is unsupported), but I think if we support the last 3 releases we're pretty good. And with GitHub deprecating macOS-12, our hands are tied anyway. |
Yes, I'll open a PR. The version we're mentioning in the docs is quite out-of-date. It's referencing macOS 10.12 Sierra from 8 years ago, not macOS 12 Monterey from 3 years ago. |
🤣 |
Allow specifying an explicit TargetFramework for integration test .csproj projects via a `TARGET_FRAMEWORK` envvar. We need this because the macos-13 runner doesn't install .NET 6 by default, which causes tests to fail for the .NET 8 job.
IsMatch now has an overload, so we have to specify the type to disambiguate.
actions/runner-images#10721: